Improve S1694: Remove part about protected constructor#9387
Merged
CristianAmbrosini merged 7 commits intomasterfrom Jun 6, 2024
Merged
Improve S1694: Remove part about protected constructor#9387CristianAmbrosini merged 7 commits intomasterfrom
CristianAmbrosini merged 7 commits intomasterfrom
Conversation
pavel-mikula-sonarsource
force-pushed
the
Pavel/S1694
branch
2 times, most recently
from
fba9349 to
4ebcc90
Compare
CristianAmbrosini
requested changes
Jun 5, 2024
Contributor
CristianAmbrosini
left a comment
CristianAmbrosini
left a comment
There was a problem hiding this comment.
A few lines can be removed without failing the UTs
analyzers/tests/SonarAnalyzer.Test/TestCases/ClassShouldNotBeAbstract.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ClassShouldNotBeAbstract.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ClassShouldNotBeAbstract.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ClassShouldNotBeAbstract.cs
Outdated
Show resolved
Hide resolved
pavel-mikula-sonarsource
removed the request for review
from zsolt-kolbay-sonarsource
pavel-mikula-sonarsource
force-pushed
the
Pavel/S1694
branch
from
2c735df to
942b0ac
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8795
Should be merged with RSPEC: https://github.com/SonarSource/rspec/pull/3960